Page MenuHomePhabricator

wallet: Make WalletInitInterface and DummyWalletInit private
ClosedPublic

Authored by Fabien on Tue, Jan 8, 22:45.

Details

Summary

Backport 1/2 of core PR12836 (commit 39bc2fa)

Test Plan
make check
bitcoin-qt --help

Ensure that bitcoind and bitcoin-qt can execute

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Jan 8, 22:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jan 8, 22:45
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox requested changes to this revision.Tue, Jan 8, 23:45
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/bitcoin.cpp
39 ↗(On Diff #6562)

This line doesn't appear in the original PR. Is there a missing backport that should be done before this one?

There are a couple removals of #include "wallet/init.h" that aren't here as well, hinting to a similar thing.

This revision now requires changes to proceed.Tue, Jan 8, 23:45
Fabien requested review of this revision.Wed, Jan 9, 06:58
Fabien added inline comments.
src/qt/bitcoin.cpp
39 ↗(On Diff #6562)

Yes, there is a missing backport : PR10244.
I think there won't be too much conflicts due to these includes, so better fix the help issue now even if the backports are not strictly ordered.

jasonbcox accepted this revision.Wed, Jan 9, 07:31
jasonbcox added inline comments.
src/qt/bitcoin.cpp
39 ↗(On Diff #6562)

Noted. T417

This revision is now accepted and ready to land.Wed, Jan 9, 07:31
deadalnix accepted this revision.Wed, Jan 9, 17:47
Closed by commit rABCb7174c604d34: wallet: Make WalletInitInterface and DummyWalletInit private (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by Fabien). · Explain WhyWed, Jan 9, 18:30
This revision was automatically updated to reflect the committed changes.