Page MenuHomePhabricator

wallet: Refactor to WalletInitInterface* const g_wallet_init_interface
ClosedPublic

Authored by Fabien on Tue, Jan 8, 22:54.

Details

Summary

Backport 2/2 of core PR12836 (commit d894894)

Depends on D2273

Test Plan
make check

Check that bitcoind and bitcoin-qt can be executed

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Jan 8, 22:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jan 8, 22:54
Herald added a subscriber: schancel. · View Herald Transcript
Fabien added inline comments.Tue, Jan 8, 22:56
src/wallet/init.cpp
7 ↗(On Diff #6563)

This include should be placed after config.h, but for some reason clang-format wants it to be in first position.

jasonbcox accepted this revision.Tue, Jan 8, 23:48
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/init.cpp
7 ↗(On Diff #6563)

I think it's because it's the header that matches this filename.

This revision is now accepted and ready to land.Tue, Jan 8, 23:48
deadalnix accepted this revision.Wed, Jan 9, 17:54
deadalnix added inline comments.
src/wallet/init.cpp
7 ↗(On Diff #6563)

Use angle brackets. We should really start to use angle bracket or we have weird ambiguous includes when names are init.h or alike.

Closed by commit rABCdac511e1e527: wallet: Refactor to WalletInitInterface* const g_wallet_init_interface (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by Fabien). · Explain WhyWed, Jan 9, 18:30
This revision was automatically updated to reflect the committed changes.