Page MenuHomePhabricator

wallet: Refactor to WalletInitInterface* const g_wallet_init_interface
ClosedPublic

Authored by Fabien on Jan 8 2019, 22:54.

Details

Summary

Backport 2/2 of core PR12836 (commit d894894)

Depends on D2273

Test Plan
make check

Check that bitcoind and bitcoin-qt can be executed

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12836_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4451
Build 6966: Bitcoin ABC Buildbot (legacy)
Build 6965: arc lint + arc unit

Event Timeline

src/wallet/init.cpp
7

This include should be placed after config.h, but for some reason clang-format wants it to be in first position.

jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/init.cpp
7

I think it's because it's the header that matches this filename.

This revision is now accepted and ready to land.Jan 8 2019, 23:48
deadalnix added inline comments.
src/wallet/init.cpp
7

Use angle brackets. We should really start to use angle bracket or we have weird ambiguous includes when names are init.h or alike.