Page MenuHomePhabricator
Differential D2273

wallet: Make WalletInitInterface and DummyWalletInit private
ClosedPublic
Actions

Authored by Fabien on Jan 8 2019, 22:45.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGb7174c604d34: wallet: Make WalletInitInterface and DummyWalletInit private
rABCb7174c604d34: wallet: Make WalletInitInterface and DummyWalletInit private
Summary

Backport 1/2 of core PR12836 (commit 39bc2fa)

Test Plan
make check
bitcoin-qt --help

Ensure that bitcoind and bitcoin-qt can execute

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12836_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4450
Build 6964: Bitcoin ABC Buildbot (legacy)
Build 6963: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 8 2019, 22:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2019, 22:45
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 8 2019, 22:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 8 2019, 22:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4450: Diff 6562.Jan 8 2019, 22:56
Fabien added a child revision: D2274: wallet: Refactor to WalletInitInterface* const g_wallet_init_interface.Jan 8 2019, 22:59
jasonbcox requested changes to this revision.Jan 8 2019, 23:45
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/bitcoin.cpp
39

This line doesn't appear in the original PR. Is there a missing backport that should be done before this one?

There are a couple removals of #include "wallet/init.h" that aren't here as well, hinting to a similar thing.

This revision now requires changes to proceed.Jan 8 2019, 23:45
Fabien requested review of this revision.Jan 9 2019, 06:58
Fabien added inline comments.
src/qt/bitcoin.cpp
39

Yes, there is a missing backport : PR10244.
I think there won't be too much conflicts due to these includes, so better fix the help issue now even if the backports are not strictly ordered.

jasonbcox accepted this revision.Jan 9 2019, 07:31
jasonbcox added inline comments.
src/qt/bitcoin.cpp
39

Noted. T417

This revision is now accepted and ready to land.Jan 9 2019, 07:31
deadalnix accepted this revision.Jan 9 2019, 17:47
Closed by commit rABCb7174c604d34: wallet: Make WalletInitInterface and DummyWalletInit private (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by Fabien). · Explain WhyJan 9 2019, 18:30
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
1 line
9 lines
19 lines
qt/
6 lines
wallet/
39 lines
13 lines

Diff 6562

View Options

src/Makefile.am

Loading...
View Options

src/bitcoind.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/wallet/init.h

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/walletinitinterface.h

Loading...