Page MenuHomePhabricator
Create Task
Maniphest T602

Backport Core PR 15288: Remove wallet -> node global function calls
Closed, ResolvedPublic
Actions

Description

https://github.com/bitcoin/bitcoin/pull/15288

Related Objects
Search...

StatusAssignedTask
 ResolvednakihitoT581 Backport Core PR 14206
 ResolvedjasonbcoxT575 Backport Core PR 14532: reduce attack surface of RPC server
 ResolvednakihitoT582 Backport Core PR 13341
 ResolvednakihitoT601 Backport Core PR 10973: Refactor: separate wallet from node
 ResolvednakihitoT602 Backport Core PR 15288: Remove wallet -> node global function calls
 ResolvednakihitoT603 Backport Core PR 10976: Refactor: separate wallet from node
 ResolvednakihitoT600 Backport Core PR 14711: Refactor: Start to separate wallet from node
 ResolvednakihitoT596 Backport Core PR 14350: Add WalletLocation class
 ResolvednakihitoT592 Backport Core PR 14437: Refactor: Start to separate wallet from node
 ResolvedjasonbcoxT590 Backport Core 14555: Move util files to new directory
 ResolvednakihitoT629 Backport Core PR 11372: Address encoding cleanup
 ResolveddeadalnixT637 Backport Core PR 14168: Remove ENABLE_WALLET from libbitcoin_server.a
 ResolvednakihitoT583 Backport Core PR 13190
 InvalidnakihitoT584 Backport Core PR 12906
 DuplicatenakihitoT585 Backport Core PR 10244
 ResolvednakihitoT586 Backport Core PR 10871
 ResolvedjasonbcoxT417 Backport PR10244 from core
 ResolvedjasonbcoxT426 Backport PR10832
 ResolvedjasonbcoxT427 Backport PR9834
 ResolvedjasonbcoxT430 Backport Core PR 11698
 ResolvedjasonbcoxT431 Backport Core PR 10362
 ResolvedjasonbcoxT432 Backport Core PR 9500
 ResolvedjasonbcoxT440 Backport Core PR 12610 and friends for multiwallet support
 ResolvedjasonbcoxT442 Backport Core PR 11335
 ResolvedjasonbcoxT441 Backport Core PR 10870
 ResolvedjasonbcoxT443 Backport Core PR 11169
 ResolvedjasonbcoxT444 Backport Core PR 10093
 ResolvedjasonbcoxT318 Backport PR 11335 to fix window restore
 ResolvedjasonbcoxT507 Backport Core PR 12266
 ResolvedjasonbcoxT510 Backport Core PR 10231
 ResolvedFabienT511 Backport Core PR 10770
 ResolvedjasonbcoxT512 Backport Core PR 10420
 ResolvedjasonbcoxT513 Backport Core PR 11365
 InvalidjasonbcoxT514 Backport Core PR 9424
 WontfixjasonbcoxT515 Backport Core PR 10449
 ResolvedjasonbcoxT508 Backport Core PR 10839
 ResolvedjasonbcoxT509 Backport Core PR 10769
 ResolvedFabienT517 Backport Core PR 9680
 ResolvedjasonbcoxT518 Backport Core PR 12276
 ResolvedjasonbcoxT519 Backport Core PR 11132
 ResolvedjasonbcoxT520 Backport Core PR 10303
 ResolvedjasonbcoxT521 Backport Core PR 10706
 ResolvedjasonbcoxT522 Backport Core PR 10390
 ResolvedjasonbcoxT516 Backport Core PR 10295
 ResolvedjasonbcoxT523 Backport Core PR10165
 ResolvedjasonbcoxT534 Backport Core PR10712
 ResolvedjasonbcoxT535 Backport Core PR10294
 ResolvedjasonbcoxT546 Partial backport of Core PR9672
 ResolvedjasonbcoxT547 Partial backport of Core PR9681
 ResolvedFabienT543 Backport PR11623
 ResolvedFabienT544 Backport PR11824
 ResolvedjasonbcoxT548 Backport Core PR 11809
 ResolvedjasonbcoxT549 Backport Core PR 10742
 ResolvedNoneT570 Backport Core PR 11923
 ResolvedjasonbcoxT550 Backport Core PR 11039
 ResolvedjasonbcoxT551 Backport Core PR 9622
 ResolvedjasonbcoxT552 Backport Core PR 10783
 ResolvedjasonbcoxT556 Backport Core PR 12327
 ResolvednakihitoT557 Backport Core PR 11733
 ResolvednakihitoT559 Backport Core PR 10964
 ResolvedjasonbcoxT560 Backport Core PR 11041
 ResolvednakihitoT561 Backport Core PR 12083
 ResolvednakihitoT566 Backport Core PR12317
 ResolvedjasonbcoxT562 Backport Core PR 10275
 ResolvedjasonbcoxT564 Backport Core PR 11027
 ResolvednakihitoT565 Backport Core PR 11529
 ResolvedjasonbcoxT563 Backport Core PR 11565
 ResolvedjasonbcoxT572 Backport Core PR 10279
 ResolvedjasonbcoxT577 Backport Core PR 10493
 ResolvedjasonbcoxT462 Backport Core PR11367 for more info in getblockchaininfo output
 ResolvednakihitoT567 Backport Core PR10858
 ResolvedjasonbcoxT593 Backport Core PR 11838
 ResolvedjasonbcoxT588 Backport Core PR 10368
 ResolvednakihitoT599 Backport Core PR 3716: GUI: Receive: Remove option to reuse a previous address
 ResolvedjasonbcoxT605 Backport Core PR 12630
 ResolvedjasonbcoxT604 Backport Core PR 11904
 ResolvednakihitoT606 Backport Core PR 11017
 ResolvedjasonbcoxT607 Backport Core PR 12422

Event Timeline

nakihito triaged this task as High priority.Apr 15 2019, 22:47
nakihito created this task.
nakihito added a subtask: T603: Backport Core PR 10976: Refactor: separate wallet from node.Apr 15 2019, 22:51
nakihito added a parent task: T601: Backport Core PR 10973: Refactor: separate wallet from node.Apr 19 2019, 21:37
majcosta mentioned this in D5869: [backport#15288] Remove use of IsInitialBlockDownload in wallet code.Apr 28 2020, 07:54
majcosta mentioned this in rABC98cf10885377: [backport#15288] Remove use of IsInitialBlockDownload in wallet code.Apr 28 2020, 19:00
majcosta closed this task as Resolved.Apr 28 2020, 19:05
majcosta added a subscriber: majcosta.

Completed in D5869

majcosta added a comment.Apr 29 2020, 12:13

note: the following commits were not backported, the first looked to me like it was RBF-relevant only, the second is made redundant by clang-format

cc02c796d3517931acc861b0f9bc50e36e1c95f9 Remove uses of fee globals in wallet code
f7efd87c8fb49f82e268a95e989909d453500e2b Change brace formatting
majcosta mentioned this in rSTAGING98cf10885377: [backport#15288] Remove use of IsInitialBlockDownload in wallet code.May 5 2020, 19:11
majcosta closed subtask T603: Backport Core PR 10976: Refactor: separate wallet from node as Resolved.Jul 22 2021, 19:45