Page MenuHomePhabricator

Remove direct bitcoin calls from qt/coincontroldialog.cpp
ClosedPublic

Authored by jasonbcox on Apr 28 2019, 16:34.

Details

Summary
Test Plan

make check
bitcoin-qt # sanity checking: use coin control dialog to select inputs for generating a tx

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox added inline comments.
src/interfaces/node.h
153 ↗(On Diff #8294)

Removed getRequiredFee since it's unnecessary and redundant with getMinimumFee

156 ↗(On Diff #8294)

Removed return_target (conf target) and reason (fee reason) since we support neither of these.

160 ↗(On Diff #8294)

Removed estimateSmartFee since we no longer support it.

src/interfaces/wallet.h
9 ↗(On Diff #8294)

Refactors that we've done must have changed how CTxOut was being implicitly included. Added explicitly so that this will compile.

jasonbcox added a reviewer: Fabien.
jasonbcox added a project: Restricted Project.
Fabien added inline comments.
src/interfaces/wallet.cpp
216 ↗(On Diff #8294)

Does this layout come from the linter ? If not can you move it to the same line as getCoins ?

This revision is now accepted and ready to land.Apr 29 2019, 08:59
src/interfaces/wallet.cpp
216 ↗(On Diff #8294)

ya, the linter did this.

This revision was automatically updated to reflect the committed changes.