Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/827de038ab6fa58aa3d46151eb2f8dc6add7743e
Progress towards T417
Details
Details
- Reviewers
deadalnix Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGINGdb889a6b6b62: Remove direct bitcoin calls from qt/coincontroldialog.cpp
rABCdb889a6b6b62: Remove direct bitcoin calls from qt/coincontroldialog.cpp
make check
bitcoin-qt # sanity checking: use coin control dialog to select inputs for generating a tx
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/interfaces/node.h | ||
|---|---|---|
| 153 ↗ | (On Diff #8294) | Removed getRequiredFee since it's unnecessary and redundant with getMinimumFee |
| 156 ↗ | (On Diff #8294) | Removed return_target (conf target) and reason (fee reason) since we support neither of these. |
| 160 ↗ | (On Diff #8294) | Removed estimateSmartFee since we no longer support it. |
| src/interfaces/wallet.h | ||
| 9 ↗ | (On Diff #8294) | Refactors that we've done must have changed how CTxOut was being implicitly included. Added explicitly so that this will compile. |
| src/interfaces/wallet.cpp | ||
|---|---|---|
| 216 ↗ | (On Diff #8294) | Does this layout come from the linter ? If not can you move it to the same line as getCoins ? |
| src/interfaces/wallet.cpp | ||
|---|---|---|
| 216 ↗ | (On Diff #8294) | ya, the linter did this. |