Page MenuHomePhabricator
Differential D2884

Remove direct bitcoin calls from qt/coincontroldialog.cpp
ClosedPublic
Actions

Authored by jasonbcox on Apr 28 2019, 16:34.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGdb889a6b6b62: Remove direct bitcoin calls from qt/coincontroldialog.cpp
rABCdb889a6b6b62: Remove direct bitcoin calls from qt/coincontroldialog.cpp
Summary

Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/827de038ab6fa58aa3d46151eb2f8dc6add7743e
Progress towards T417

Test Plan

make check
bitcoin-qt # sanity checking: use coin control dialog to select inputs for generating a tx

Diff Detail

Repository
rABC Bitcoin ABC
Branch
coincontrol
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5616
Build 9294: Bitcoin ABC Buildbot (legacy)
Build 9293: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 28 2019, 16:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2019, 16:34
Herald added a reviewer: deadalnix. · View Herald Transcript
jasonbcox planned changes to this revision.Apr 28 2019, 16:34
teamcity added a comment.Apr 28 2019, 16:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 28 2019, 16:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5616: Diff 8294.Apr 28 2019, 16:49
jasonbcox requested review of this revision.Apr 29 2019, 00:29
jasonbcox added inline comments.
src/interfaces/node.h
153

Removed getRequiredFee since it's unnecessary and redundant with getMinimumFee

156

Removed return_target (conf target) and reason (fee reason) since we support neither of these.

160

Removed estimateSmartFee since we no longer support it.

src/interfaces/wallet.h
9

Refactors that we've done must have changed how CTxOut was being implicitly included. Added explicitly so that this will compile.

jasonbcox edited the test plan for this revision. (Show Details)Apr 29 2019, 00:30
jasonbcox added a reviewer: Fabien.
jasonbcox added a project: Restricted Project.
Fabien accepted this revision.Apr 29 2019, 08:59
Fabien added inline comments.
src/interfaces/wallet.cpp
216

Does this layout come from the linter ? If not can you move it to the same line as getCoins ?

This revision is now accepted and ready to land.Apr 29 2019, 08:59
jasonbcox added inline comments.Apr 29 2019, 16:14
src/interfaces/wallet.cpp
216

ya, the linter did this.

Closed by commit rABCdb889a6b6b62: Remove direct bitcoin calls from qt/coincontroldialog.cpp (authored by jasonbcox). · Explain WhyApr 29 2019, 16:18
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D2889: Remove direct bitcoin calls from qt/sendcoinsdialog.cpp.Apr 29 2019, 22:32
jasonbcox added a commit: rSTAGINGdb889a6b6b62: Remove direct bitcoin calls from qt/coincontroldialog.cpp.Sep 18 2019, 23:09

Revision Contents
Changeset List

PathSize
src/
interfaces/
12 lines
12 lines
21 lines
42 lines
qt/
108 lines
5 lines
37 lines

Diff 8294

View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/coincontroldialog.cpp

Loading...
View Options

src/qt/walletmodel.h

Loading...
View Options

src/qt/walletmodel.cpp

Loading...