Page MenuHomePhabricator

Remove direct bitcoin calls from qt/splashscreen.cpp
ClosedPublic

Authored by jasonbcox on Apr 17 2019, 17:29.

Details

Summary
Test Plan

make check
ninja
bitcoin-qt # sanity checking

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fixed linker issues in the CMake build

deadalnix requested changes to this revision.Apr 17 2019, 23:11
deadalnix added inline comments.
src/CMakeLists.txt
137 โ†—(On Diff #8103)

This is incorrect.

This revision now requires changes to proceed.Apr 17 2019, 23:11

Fixed linking in CMake build.
interface -> interfaces
Rebase

deadalnix requested changes to this revision.Apr 19 2019, 12:51
deadalnix added inline comments.
src/CMakeLists.txt
313 โ†—(On Diff #8125)

This can't possibly be correct.

This revision now requires changes to proceed.Apr 19 2019, 12:51

Rebase (with D2842, fixing the linking issue)

Fabien requested changes to this revision.Apr 20 2019, 12:51
Fabien added inline comments.
src/interfaces/wallet.h
5 โ†—(On Diff #8173)

BITCOIN_INTERFACE_WALLET_H => BITCOIN_INTERFACES_WALLET_H

6 โ†—(On Diff #8173)

Dito.

35 โ†—(On Diff #8173)

Dito.

src/qt/splashscreen.cpp
22 โ†—(On Diff #8173)

This is removed in the original PR

This revision now requires changes to proceed.Apr 20 2019, 12:51

Fixed includes (and angle brackets) + header guards

This revision is now accepted and ready to land.Apr 23 2019, 20:50
This revision was automatically updated to reflect the committed changes.