Page MenuHomePhabricator

Remove direct bitcoin calls from qt/splashscreen.cpp
ClosedPublic

Authored by jasonbcox on Apr 17 2019, 17:29.

Details

Summary
Test Plan

make check
ninja
bitcoin-qt # sanity checking

Diff Detail

Repository
rABC Bitcoin ABC
Branch
c6
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5488
Build 9038: Bitcoin ABC Teamcity Staging
Build 9037: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 17 2019, 17:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2019, 17:29
jasonbcox updated this revision to Diff 8103.Apr 17 2019, 17:35

Fixed linker issues in the CMake build

jasonbcox edited the test plan for this revision. (Show Details)Apr 17 2019, 18:17
deadalnix requested changes to this revision.Apr 17 2019, 23:11
deadalnix added inline comments.
src/CMakeLists.txt
137

This is incorrect.

This revision now requires changes to proceed.Apr 17 2019, 23:11
jasonbcox updated this revision to Diff 8125.Apr 18 2019, 20:42

Fixed linking in CMake build.
interface -> interfaces
Rebase

deadalnix requested changes to this revision.Apr 19 2019, 12:51
deadalnix added inline comments.
src/CMakeLists.txt
313 ↗(On Diff #8125)

This can't possibly be correct.

This revision now requires changes to proceed.Apr 19 2019, 12:51
jasonbcox updated this revision to Diff 8173.Apr 19 2019, 21:34

Rebase (with D2842, fixing the linking issue)

Fabien requested changes to this revision.Apr 20 2019, 12:51
Fabien added inline comments.
src/interfaces/wallet.h
5 ↗(On Diff #8173)

BITCOIN_INTERFACE_WALLET_H => BITCOIN_INTERFACES_WALLET_H

6 ↗(On Diff #8173)

Dito.

35 ↗(On Diff #8173)

Dito.

src/qt/splashscreen.cpp
22 ↗(On Diff #8173)

This is removed in the original PR

This revision now requires changes to proceed.Apr 20 2019, 12:51
jasonbcox updated this revision to Diff 8187.Apr 20 2019, 16:46

Fixed includes (and angle brackets) + header guards

Fabien accepted this revision.Apr 21 2019, 19:55
deadalnix accepted this revision.Apr 23 2019, 20:50
This revision is now accepted and ready to land.Apr 23 2019, 20:50
This revision was automatically updated to reflect the committed changes.