Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING11a062c29019: Remove direct bitcoin calls from qt/peertablemodel.cpp
rABC11a062c29019: Remove direct bitcoin calls from qt/peertablemodel.cpp

Summary

Partial backport of Core PR 102444
https://github.com/bitcoin/bitcoin/pull/10244/commits/e0b66a3b7c5d3a079636d61fcf611bb6b36c7bc1
Progress towards T417
Depends on D2819

Test Plan

make check
ninja
bitcoin-qt # sanity checking; check peer table in debug window

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Apr 17 2019, 23:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2019, 23:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Removed QT_VERSION check for an old version that we do not support

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix requested changes to this revision.Apr 17 2019, 23:18

deadalnix added inline comments.

src/qt/peertablemodel.cpp
9 ↗	(On Diff #8112)	This shouldn't compile. Congratulation, you found a problem in the build system and introduced a new problem.

This revision now requires changes to proceed.Apr 17 2019, 23:18

jasonbcox added a child revision: D2822: Remove direct bitcoin calls from qt/bantablemodel.cpp.Apr 17 2019, 23:23

Harbormaster completed remote builds in B5492: Diff 8111.Apr 17 2019, 23:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5493: Diff 8112.Apr 17 2019, 23:27

jasonbcox edited the test plan for this revision. (Show Details)Apr 18 2019, 00:42

Fixed qt includes. Ongoing discussion in Slack for how to tackle this problem more permanently.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5499: Diff 8118.Apr 18 2019, 00:59

Fabien added inline comments.Apr 18 2019, 08:15

src/qt/peertablemodel.cpp
97 ↗	(On Diff #8118)	This needs a rebase

jasonbcox planned changes to this revision.Apr 18 2019, 18:21

Rebase, interface -> interfaces, peertablemodel.h using angle brackets

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5535: Diff 8176.Apr 19 2019, 22:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.Apr 20 2019, 13:18

Fabien added inline comments.

src/qt/peertablemodel.cpp
13 ↗	(On Diff #8176)	Move above `<sync.h>` to avoid later merge conflicts

deadalnix accepted this revision.Apr 23 2019, 20:53

This revision is now accepted and ready to land.Apr 23 2019, 20:53

Closed by commit rABC11a062c29019: Remove direct bitcoin calls from qt/peertablemodel.cpp (authored by Russell Yanofsky <russ@yanofsky.org>, committed by jasonbcox). · Explain WhyApr 23 2019, 22:06

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING11a062c29019: Remove direct bitcoin calls from qt/peertablemodel.cpp.Sep 18 2019, 23:07

Remove direct bitcoin calls from qt/peertablemodel.cpp
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 8248

src/interfaces/node.h

src/interfaces/node.cpp

src/net_processing.h

src/qt/clientmodel.cpp

src/qt/peertablemodel.h

src/qt/peertablemodel.cpp

Remove direct bitcoin calls from qt/peertablemodel.cppClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8248

src/interfaces/node.h

src/interfaces/node.cpp

src/net_processing.h

src/qt/clientmodel.cpp

src/qt/peertablemodel.h

src/qt/peertablemodel.cpp

Remove direct bitcoin calls from qt/peertablemodel.cpp
ClosedPublic
Actions

Revision Contents
Changeset List