Page MenuHomePhabricator

Remove direct bitcoin calls from qt/peertablemodel.cpp
ClosedPublic

Authored by jasonbcox on Apr 17 2019, 23:10.

Details

Summary
Test Plan

make check
ninja
bitcoin-qt # sanity checking; check peer table in debug window

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Apr 17 2019, 23:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2019, 23:10
jasonbcox updated this revision to Diff 8112.Apr 17 2019, 23:12

Removed QT_VERSION check for an old version that we do not support

deadalnix requested changes to this revision.Apr 17 2019, 23:18
deadalnix added inline comments.
src/qt/peertablemodel.cpp
9 ↗(On Diff #8112)

This shouldn't compile. Congratulation, you found a problem in the build system and introduced a new problem.

This revision now requires changes to proceed.Apr 17 2019, 23:18
jasonbcox edited the test plan for this revision. (Show Details)Apr 18 2019, 00:42
jasonbcox updated this revision to Diff 8118.Apr 18 2019, 00:45

Fixed qt includes. Ongoing discussion in Slack for how to tackle this problem more permanently.

Fabien added inline comments.Apr 18 2019, 08:15
src/qt/peertablemodel.cpp
97 ↗(On Diff #8118)

This needs a rebase

jasonbcox planned changes to this revision.Apr 18 2019, 18:21
jasonbcox updated this revision to Diff 8176.Apr 19 2019, 22:35

Rebase, interface -> interfaces, peertablemodel.h using angle brackets

Fabien accepted this revision.Apr 20 2019, 13:18
Fabien added inline comments.
src/qt/peertablemodel.cpp
13 ↗(On Diff #8176)

Move above <sync.h> to avoid later merge conflicts

deadalnix accepted this revision.Apr 23 2019, 20:53
This revision is now accepted and ready to land.Apr 23 2019, 20:53
This revision was automatically updated to reflect the committed changes.