Page MenuHomePhabricator

Remove direct bitcoin calls from qt/peertablemodel.cpp
ClosedPublic

Authored by jasonbcox on Apr 17 2019, 23:10.

Details

Summary
Test Plan

make check
ninja
bitcoin-qt # sanity checking; check peer table in debug window

Diff Detail

Repository
rABC Bitcoin ABC
Branch
c8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5492
Build 9046: Bitcoin ABC Buildbot (legacy)
Build 9045: arc lint + arc unit

Event Timeline

Removed QT_VERSION check for an old version that we do not support

deadalnix requested changes to this revision.Apr 17 2019, 23:18
deadalnix added inline comments.
src/qt/peertablemodel.cpp
9 ↗(On Diff #8112)

This shouldn't compile. Congratulation, you found a problem in the build system and introduced a new problem.

This revision now requires changes to proceed.Apr 17 2019, 23:18

Fixed qt includes. Ongoing discussion in Slack for how to tackle this problem more permanently.

src/qt/peertablemodel.cpp
97 ↗(On Diff #8118)

This needs a rebase

Rebase, interface -> interfaces, peertablemodel.h using angle brackets

Fabien added inline comments.
src/qt/peertablemodel.cpp
13 ↗(On Diff #8176)

Move above <sync.h> to avoid later merge conflicts

This revision is now accepted and ready to land.Apr 23 2019, 20:53
This revision was automatically updated to reflect the committed changes.