Page MenuHomePhabricator

Move interface -> interfaces
ClosedPublic

Authored by jasonbcox on Apr 18 2019, 16:48.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rABCfb9cfdfcfbf3: Move interface -> interfaces
Summary

Core PR 12906 ( https://github.com/bitcoin/bitcoin/pull/12906/files ) renames these files.
Rather than applying this large refactor patch after the completion of T417, I'm applying part of it now
and will be applying the rest of it in-place for the remaining T417 diffs.

Test Plan

make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Apr 18 2019, 16:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2019, 16:48
jasonbcox planned changes to this revision.Apr 18 2019, 17:48
jasonbcox updated this revision to Diff 8122.Apr 18 2019, 18:14

Renaming the namespaces which should have been included the first time around

Fabien requested changes to this revision.Apr 19 2019, 08:05
Fabien added inline comments.
src/interfaces/handler.h
5 ↗(On Diff #8122)

BITCOIN_INTERFACE_HANDLER_H => BITCOIN_INTERFACES_HANDLER_H

6 ↗(On Diff #8122)

dito

34 ↗(On Diff #8122)

dito

This revision now requires changes to proceed.Apr 19 2019, 08:05
deadalnix accepted this revision.Apr 19 2019, 12:08
jasonbcox updated this revision to Diff 8151.Apr 19 2019, 16:44

Rebase + update header guards

Fabien accepted this revision.Apr 19 2019, 18:19
This revision is now accepted and ready to land.Apr 19 2019, 18:19
This revision was automatically updated to reflect the committed changes.