Page MenuHomePhabricator

Remove direct bitcoin calls from qt/utilitydialog.cpp
ClosedPublic

Authored by jasonbcox on Apr 17 2019, 17:12.

Details

Summary
Test Plan
make check
ninja check
bitcoin-qt # sanity checking
bitcoin-qt -help
bitcoin-qt -version

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Apr 17 2019, 17:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2019, 17:12
deadalnix requested changes to this revision.Apr 17 2019, 23:08
deadalnix added inline comments.
src/qt/bitcoin.cpp
652 ↗(On Diff #8101)

You need to check -help and -version as part of your test plan.

This revision now requires changes to proceed.Apr 17 2019, 23:08
jasonbcox requested review of this revision.Apr 18 2019, 00:09
jasonbcox edited the test plan for this revision. (Show Details)
jasonbcox marked an inline comment as done.
Fabien requested changes to this revision.Apr 18 2019, 06:13
Fabien added inline comments.
src/qt/utilitydialog.h
14 ↗(On Diff #8101)

You should rename to interfaces: https://github.com/bitcoin/bitcoin/pull/12906

This revision now requires changes to proceed.Apr 18 2019, 06:13
jasonbcox updated this revision to Diff 8123.Apr 18 2019, 18:20

interface -> interfaces

jasonbcox edited the summary of this revision. (Show Details)Apr 18 2019, 18:20
jasonbcox edited the test plan for this revision. (Show Details)
Fabien accepted this revision.Apr 19 2019, 07:11
deadalnix accepted this revision.Apr 19 2019, 12:50
This revision is now accepted and ready to land.Apr 19 2019, 12:50
This revision was automatically updated to reflect the committed changes.