Page MenuHomePhabricator
Differential D2816

Remove direct bitcoin calls from qt/utilitydialog.cpp
ClosedPublic
Actions

Authored by jasonbcox on Apr 17 2019, 17:12.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGd166b08cb29b: Remove direct bitcoin calls from qt/utilitydialog.cpp
rABCd166b08cb29b: Remove direct bitcoin calls from qt/utilitydialog.cpp
Summary

Partial backport for Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/c2f672fb1960399389dea9cdd8f76d7156c2c88b
Progress towards T417
Depends on D2815, D2826

Test Plan
make check
ninja check
bitcoin-qt # sanity checking
bitcoin-qt -help
bitcoin-qt -version

Diff Detail

Repository
rABC Bitcoin ABC
Branch
c4b
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5504
Build 9070: Bitcoin ABC Buildbot (legacy)
Build 9069: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 17 2019, 17:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2019, 17:12
teamcity added a comment.Apr 17 2019, 17:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5486: Diff 8101.Apr 17 2019, 17:26
teamcity added a comment.Apr 17 2019, 17:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix requested changes to this revision.Apr 17 2019, 23:08
deadalnix added inline comments.
src/qt/bitcoin.cpp
652 ↗(On Diff #8101)

You need to check -help and -version as part of your test plan.

This revision now requires changes to proceed.Apr 17 2019, 23:08
jasonbcox requested review of this revision.Apr 18 2019, 00:09
jasonbcox edited the test plan for this revision. (Show Details)
jasonbcox marked an inline comment as done.
Fabien requested changes to this revision.Apr 18 2019, 06:13
Fabien added inline comments.
src/qt/utilitydialog.h
14 ↗(On Diff #8101)

You should rename to interfaces: https://github.com/bitcoin/bitcoin/pull/12906

This revision now requires changes to proceed.Apr 18 2019, 06:13
jasonbcox added a child revision: D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.Apr 18 2019, 17:32
jasonbcox updated this revision to Diff 8123.Apr 18 2019, 18:20

interface -> interfaces

jasonbcox edited the summary of this revision. (Show Details)Apr 18 2019, 18:20
jasonbcox added a parent revision: D2826: Move interface -> interfaces.
jasonbcox edited the test plan for this revision. (Show Details)
teamcity added a comment.Apr 18 2019, 18:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 18 2019, 18:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5504: Diff 8123.Apr 18 2019, 18:34
Fabien accepted this revision.Apr 19 2019, 07:11
deadalnix accepted this revision.Apr 19 2019, 12:50
This revision is now accepted and ready to land.Apr 19 2019, 12:50
jasonbcox updated this revision to Diff 8152.Apr 19 2019, 16:58

Rebase

teamcity added a comment.Apr 19 2019, 16:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 19 2019, 17:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5526: Diff 8152.Apr 19 2019, 17:11
Closed by commit rABCd166b08cb29b: Remove direct bitcoin calls from qt/utilitydialog.cpp (authored by Russell Yanofsky <russ@yanofsky.org>, committed by jasonbcox). · Explain WhyApr 19 2019, 20:04
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGINGd166b08cb29b: Remove direct bitcoin calls from qt/utilitydialog.cpp.Sep 18 2019, 23:03

Revision Contents
Changeset List

PathSize
src/
interfaces/
4 lines
3 lines
qt/
2 lines
4 lines
7 lines
6 lines

Diff 8123

View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/utilitydialog.h

Loading...
View Options

src/qt/utilitydialog.cpp

Loading...