Page MenuHomePhabricator
Differential D3630

[wallet] setup wallet background flushing in WalletInit directly
ClosedPublic
Actions

Authored by Fabien on Jul 10 2019, 09:59.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8b39a91fe12f: [wallet] setup wallet background flushing in WalletInit directly
rABC8b39a91fe12f: [wallet] setup wallet background flushing in WalletInit directly
Summary
WalletInit::Start calls postInitProcess() for each wallet. Previously
each call to postInitProcess() would attempt to schedule wallet
background flushing.

Just start wallet background flushing once from WalletInit::Start().

Partial backport of core PR10740 (commit 470316c)
https://github.com/bitcoin/bitcoin/pull/10740/commits/470316c3bf5ca343d5d66b94839169a4572eceb7

Progress towards T459

Test Plan
make check
./test/functional/test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10740_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6828
Build 11703: Bitcoin ABC Buildbot (legacy)
Build 11702: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 10 2019, 09:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2019, 09:59
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jul 10 2019, 09:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2019, 10:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6793: Diff 10189.Jul 10 2019, 10:06
deadalnix accepted this revision.Jul 11 2019, 01:49
deadalnix added inline comments.
src/wallet/init.cpp
400 ↗(On Diff #10189)

Do you actually need the full trinity here ?

This revision is now accepted and ready to land.Jul 11 2019, 01:49
Fabien updated this revision to Diff 10240.Jul 11 2019, 19:47

Remove () from the predicate.

teamcity added a comment.Jul 11 2019, 19:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 11 2019, 19:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6828: Diff 10240.Jul 11 2019, 19:54
Closed by commit rABC8b39a91fe12f: [wallet] setup wallet background flushing in WalletInit directly (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJul 11 2019, 20:00
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC8b39a91fe12f: [wallet] setup wallet background flushing in WalletInit directly.
Fabien added a commit: rSTAGING8b39a91fe12f: [wallet] setup wallet background flushing in WalletInit directly.Sep 19 2019, 01:12

Revision Contents
Changeset List

PathSize
src/
wallet/
11 lines
3 lines
15 lines

Diff 10240

View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...