Page MenuHomePhabricator

QA: Fix race condition in wallet_encryption test
ClosedPublic

Authored by Fabien on Jul 22 2019, 06:33.

Details

Summary
There is some imprecision probably in the internal HTTPRPCTimer class
(haven't exactly figured out where).
But we can't expect that waiting exactly 2 seconds right after calling
walletpassphrase(2) will result in a locked wallet due to the nature how
we internally handle threads/timers.

The wallet_encryption test fails regularly in CIs.

Backport of core PR16420
https://github.com/bitcoin/bitcoin/pull/16420/files

Test Plan
for i in {1..100}
do
  ./test/functional/test_runner.py wallet_encryption
done

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16420
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6897
Build 11841: Bitcoin ABC Buildbot (legacy)
Build 11840: arc lint + arc unit