Move PHPCS config file where it is used
ClosedPublic
Actions

Authored by deadalnix on Jul 22 2019, 21:02.

Details

Reviewers

jasonbcox
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING017d7e26c59f: Move PHPCS config file where it is used
rABC017d7e26c59f: Move PHPCS config file where it is used

Summary

As per title.

Test Plan

arc lint--everything

PHPCS still complains like before.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

phpfmtlocation

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6912
Build 11871: Bitcoin ABC Buildbot (legacy)
Build 11870: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 22 2019, 21:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 22 2019, 21:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix edited the test plan for this revision. (Show Details)Jul 22 2019, 21:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6912: Diff 10390.Jul 22 2019, 21:09

Really confused about where the direction of this is heading. See D3288 which renamed away from a similar name, and in a location that used to be here but was actually better (arcanist/linter/ rather than arcanist/). What's the correct name/location and why?

This revision now requires changes to proceed.Jul 22 2019, 21:12

This is where the PHP code is.

Fabien accepted this revision.Jul 24 2019, 13:40

jasonbcox accepted this revision.Jul 24 2019, 22:26

This revision is now accepted and ready to land.Jul 24 2019, 22:26

Closed by commit rABC017d7e26c59f: Move PHPCS config file where it is used (authored by deadalnix). · Explain WhyJul 24 2019, 23:36

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC017d7e26c59f: Move PHPCS config file where it is used.

deadalnix added a commit: rSTAGING017d7e26c59f: Move PHPCS config file where it is used.Sep 19 2019, 01:25