Page MenuHomePhabricator

build: Guard against accidental introduction of new Boost dependencies
ClosedPublic

Authored by Fabien on Jul 24 2019, 13:15.

Details

Summary
Guard against accidental introduction of new Boost dependencies.

Context: #13383  the usage of boost::lexical_cast was introduced in
#11517 from December 2017

Backport of core PR13385
https://github.com/bitcoin/bitcoin/pull/13385/files

The lint-include.sh has been renamed as all the other parts of it
(apart from the boost dependency checks) have been ported as arcanist
linters.

The expected list has been updated to reflect our codebase.

Test Plan

Should return no error:

./test/lint/lint-boost-dependencies.sh

Comment one of the expected boost include and run again. Check the error
is found.
Add a boost/dummy.hpp to the expected list and run again. Check the
linter displays a Good job! message.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13385
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6936
Build 11919: Bitcoin ABC Buildbot (legacy)
Build 11918: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jul 24 2019, 14:45