HomePhabricator

build: Guard against accidental introduction of new Boost dependencies

Description

build: Guard against accidental introduction of new Boost dependencies

Summary:

Guard against accidental introduction of new Boost dependencies.

Context: #13383  the usage of boost::lexical_cast was introduced in
#11517 from December 2017

Backport of core PR13385
https://github.com/bitcoin/bitcoin/pull/13385/files

The lint-include.sh has been renamed as all the other parts of it
(apart from the boost dependency checks) have been ported as arcanist
linters.

The expected list has been updated to reflect our codebase.

Test Plan:
Should return no error:

./test/lint/lint-boost-dependencies.sh

Comment one of the expected boost include and run again. Check the error
is found.
Add a boost/dummy.hpp to the expected list and run again. Check the
linter displays a Good job! message.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D3723

Details

Provenance
practicalswift <practicalswift@users.noreply.github.com>Authored on Jun 3 2018, 19:33
FabienCommitted on Jul 24 2019, 18:13
jasonbcoxPushed on Jul 24 2019, 20:00
Reviewer
Restricted Project
Differential Revision
D3723: build: Guard against accidental introduction of new Boost dependencies
Parents
rSTAGINGee141863102d: Fix phpcs warnings for unused function parameters
Branches
Unknown
Tags
Unknown