Page MenuHomePhabricator

Add src/rpc/abc.cpp to the files checked by check-rpc-mappings
ClosedPublic

Authored by Fabien on Jul 26 2019, 09:54.

Details

Summary

Add the Bitcoin-ABC specific RPCs to the check script.

Test Plan

Should return no error:

./test/lint/check-rpc-mappings.py .

Add the following line to the vRPCConvertParams[] table in
src/rpc/client.cpp:

{"setexcessiveblock", 1, "dummy"},

Then:

./test/lint/check-rpc-mappings.py .

Should trigger an error:

setexcessiveblock argument 1 (named dummy in vRPCConvertParams) is not
defined in dispatch table

Diff Detail

Repository
rABC Bitcoin ABC
Branch
check_rpc_mappings_add_abc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6979
Build 12005: Bitcoin ABC Buildbot (legacy)
Build 12004: arc lint + arc unit

Event Timeline

This doesn't look like it's going to be very useful if thins are working this way as we'll keep forgetting to add files in there.

You should consider changing the script to use a regex or something.

This revision is now accepted and ready to land.Jul 29 2019, 00:32

Will address in a follow-up