Page MenuHomePhabricator
Differential D3966

Default to defining endian-conversion DECLs in compat w/o config
ClosedPublic
Actions

Authored by fpelliccioni on Aug 28 2019, 20:03.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING1bf9852e2c50: Default to defining endian-conversion DECLs in compat w/o config
rABC1bf9852e2c50: Default to defining endian-conversion DECLs in compat w/o config
Summary

Backport of Bitcoin Core PR12998
https://github.com/bitcoin/bitcoin/pull/12998

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-3e60b9cfa
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7271
Build 12587: Bitcoin ABC Buildbot (legacy)
Build 12586: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Aug 28 2019, 20:03
Owners added a reviewer: Restricted Owners Package.Aug 28 2019, 20:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2019, 20:03
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 28 2019, 20:03

Build Bitcoin-ABC / Diffs / Diff Testing started.

fpelliccioni added a reviewer: Fabien.Aug 28 2019, 20:04
teamcity added a comment.Aug 28 2019, 20:11

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7271: Diff 11010.Aug 28 2019, 20:11
deadalnix accepted this revision.Aug 30 2019, 13:05

I'm not convinced this is really useful for us as we are moving toward cmake and always generating the config anyways, but it has value for consistency.

This revision is now accepted and ready to land.Aug 30 2019, 13:05
Closed by commit rABC1bf9852e2c50: Default to defining endian-conversion DECLs in compat w/o config (authored by Matt Corallo <git@bluematt.me>, committed by fpelliccioni). · Explain WhySep 2 2019, 17:46
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC1bf9852e2c50: Default to defining endian-conversion DECLs in compat w/o config.
fpelliccioni added a commit: rSTAGING1bf9852e2c50: Default to defining endian-conversion DECLs in compat w/o config.Sep 19 2019, 02:06

Revision Contents
Changeset List

PathSize
src/
compat/
45 lines

Diff 11010

View Options

src/compat/endian.h

Loading...