Page MenuHomePhabricator
Differential D3963

Fix deprecated copy warnings in amount.h
ClosedPublic
Actions

Authored by deadalnix on Aug 28 2019, 16:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING1cf3629759b9: Fix deprecated copy warnings in amount.h
rABC1cf3629759b9: Fix deprecated copy warnings in amount.h
Summary

This is a warning that is enabled by default on modern versions of GCC. Out code is tripping this in the Amount class.

Test Plan

Build and ensure that warnings in Amount when building with GCC9.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
implicitdeprecated
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7289
Build 12623: Bitcoin ABC Buildbot (legacy)
Build 12622: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 28 2019, 16:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2019, 16:41
teamcity added a comment.Aug 28 2019, 16:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 28 2019, 16:54

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7263: Diff 10999.Aug 28 2019, 16:54
deadalnix updated this revision to Diff 11042.Aug 30 2019, 13:00

Remove flags twiddling

teamcity added a comment.Aug 30 2019, 13:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix retitled this revision from Enable deprecated copy warnings to Fix deprecated copy warnings in amount.h.Aug 30 2019, 13:06
deadalnix edited the summary of this revision. (Show Details)
Fabien accepted this revision.Aug 30 2019, 13:07
This revision is now accepted and ready to land.Aug 30 2019, 13:07
This revision was landed with ongoing or failed builds.Aug 30 2019, 13:11
Closed by commit rABC1cf3629759b9: Fix deprecated copy warnings in amount.h (authored by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC1cf3629759b9: Fix deprecated copy warnings in amount.h.
teamcity added a comment.Aug 30 2019, 13:15

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7289: Diff 11042.Aug 30 2019, 13:15
deadalnix added a commit: rSTAGING1cf3629759b9: Fix deprecated copy warnings in amount.h.Sep 19 2019, 02:05
PiRK mentioned this in D13270: Make Amount trivially copyable.Mar 10 2023, 12:50
PiRK mentioned this in rABCbc4e81898f79: Make Amount trivially copyable.Mar 10 2023, 14:40

Revision Contents
Changeset List

PathSize
src/
10 lines

Diff 11042

View Options

src/amount.h

Loading...