Page MenuHomePhabricator

Fix RPC signrawtransaction silently accepting missing amount field, make it throw an error instead
AbandonedPublic

Authored by CCulianu on Aug 8 2017, 15:05.

Details

Reviewers
deadalnix
freetrader
dgenr8
Group Reviewers
Restricted Project
Summary

After hard fork, replay protected tx's require the amount field to be non-zero for previous outputs in signed tx's. JSON RPC code was accepting transactions with this field missing when it should have been throwing an error. Users had the impression the transaction that was signed was good, but when trying to sent to network, they would get an error that the tx is bad. See github issue https://github.com/Bitcoin-ABC/bitcoin-abc/issues/63.

Test Plan

make check and also rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
issue63_amount
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 695
Build 695: arc lint + arc unit