Page MenuHomePhabricator

Bugfix: NSIS: Exclude Makefile* from docs
ClosedPublic

Authored by Fabien on Sep 6 2019, 15:28.

Details

Summary
Otherwise, the generated Makefile is included in the NSIS-installed
documentation, which can lead to non-determinism (eg, if gawk is
installed on some build VMs, but others only have mawk)

Backport of core PR14018
https://github.com/bitcoin/bitcoin/pull/14018/files

I was hoping that it would make the gitian windows build deterministic
but it is not enough. Still good to backport anyway.

Test Plan

Run the windows gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14018
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7344
Build 12731: Bitcoin ABC Buildbot (legacy)
Build 12730: arc lint + arc unit