Page MenuHomePhabricator
Differential D4030

Activate consensus rule based on consensus params rather than config
ClosedPublic
Actions

Authored by deadalnix on Sep 11 2019, 08:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING35bb8e40f091: Activate consensus rule based on consensus params rather than config
rABC35bb8e40f091: Activate consensus rule based on consensus params rather than config
Summary

Passing a config down add needeless dependency on the config object.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
consensusactivate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7381
Build 12805: Bitcoin ABC Buildbot (legacy)
Build 12804: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 11 2019, 08:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2019, 08:04
teamcity added a comment.Sep 11 2019, 08:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a child revision: D4031: Use Consensus::Params in ContextualCheckTransaction and variations instead of Config.Sep 11 2019, 08:09
teamcity added a comment.Sep 11 2019, 08:12

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7381: Diff 11186.Sep 11 2019, 08:12
deadalnix added a child revision: D4032: Remove dependency on Config from the PoW code.Sep 11 2019, 09:24
Fabien accepted this revision.Sep 11 2019, 14:32
This revision is now accepted and ready to land.Sep 11 2019, 14:32
Closed by commit rABC35bb8e40f091: Activate consensus rule based on consensus params rather than config (authored by deadalnix). · Explain WhySep 11 2019, 15:05
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC35bb8e40f091: Activate consensus rule based on consensus params rather than config.
deadalnix added a commit: rSTAGING35bb8e40f091: Activate consensus rule based on consensus params rather than config.Sep 19 2019, 02:14

Revision Contents
Changeset List

PathSize
src/
consensus/
17 lines
39 lines
5 lines
2 lines
2 lines
test/
14 lines
81 lines

Diff 11186

View Options

src/consensus/activation.h

Loading...
View Options

src/consensus/activation.cpp

Loading...
View Options

src/consensus/tx_verify.cpp

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/pow.cpp

Loading...
View Options

src/test/activation_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...