[build] Tune wildcards for LIBSECP256K1 target
AbandonedPublic
Actions

Authored by fpelliccioni on Sep 12 2019, 20:55.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Summary

Automake would think the target was out of date every time because e.g. '.deps' was updated.

Backport of Bitcoin Core PR12788
https://github.com/bitcoin/bitcoin/pull/12788

Test Plan

make check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

feature-backport-287e4edc2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7440
Build 12923: Bitcoin ABC Buildbot (legacy)
Build 12922: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 12 2019, 20:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2019, 20:55

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7440: Diff 11272!Sep 12 2019, 21:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7440: Diff 11272.Sep 13 2019, 04:48

Build Bitcoin-ABC / Diffs / Diff Testing passed.

The test plan is inadequate.

This revision now requires changes to proceed.Sep 13 2019, 06:12

As I told Fabien a few hours ago, I will avoid (for the moment) doing backports related to the build system.

Revision Contents
Changeset List

Path

Size

src/

Makefile.am

2 lines

Diff 11272

View Options

[build] Tune wildcards for LIBSECP256K1 targetAbandonedPublicActions