bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err
AbandonedPublic
Actions

Authored by fpelliccioni on Sep 12 2019, 21:01.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Summary

A check was added to the bitcoinconsensus verify_script codepath to ensure that callers only used _exposed_ interpreter flags. I think this error should be written to bitcoinconsensus_err* err and not returned by verify_script?

Backport of Bitcoin Core PR13655
https://github.com/bitcoin/bitcoin/pull/13655

Test Plan

make check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

feature-backport-585db54dd

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7441
Build 12925: Bitcoin ABC Buildbot (legacy)
Build 12924: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 12 2019, 21:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2019, 21:01

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster failed remote builds in B7441: Diff 11273!Sep 12 2019, 21:03

Build Bitcoin-ABC / Diffs / Diff Testing failed.

segwit related, I have to re-check it.

Revision Contents
Changeset List

Path

Size

src/

script/

bitcoinconsensus.cpp

2 lines

test/

script_tests.cpp

154 lines

Diff 11273

View Options

src/script/bitcoinconsensus.cpp