Add recommendation: By default, declare single-argument constructors `explicit`
ClosedPublic
Actions

Authored by deadalnix on Sep 16 2019, 11:42.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING0643cf7b9687: Add recommendation: By default, declare single-argument constructors `explicit`
rABC0643cf7b9687: Add recommendation: By default, declare single-argument constructors `explicit`

Summary

This is a backport of Core PR11112

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr11112

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7478
Build 12999: Bitcoin ABC Buildbot (legacy)
Build 12998: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 16 2019, 11:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2019, 11:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix mentioned this in D4091: Use C++11 default member initializers.Sep 16 2019, 11:45

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7478: Diff 11343.Sep 16 2019, 11:52

Fabien accepted this revision.Sep 16 2019, 12:59

This revision is now accepted and ready to land.Sep 16 2019, 12:59

Closed by commit rABC0643cf7b9687: Add recommendation: By default, declare single-argument constructors `explicit` (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhySep 16 2019, 14:40

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC0643cf7b9687: Add recommendation: By default, declare single-argument constructors `explicit`.

deadalnix added a commit: rSTAGING0643cf7b9687: Add recommendation: By default, declare single-argument constructors `explicit`.Sep 19 2019, 02:23

Revision Contents
Changeset List

Path

Size

doc/

developer-notes.md

6 lines

src/

test/

addrman_tests.cpp

2 lines

Diff 11343

View Options

doc/developer-notes.md