Page MenuHomePhabricator

Use C++11 default member initializers
ClosedPublic

Authored by deadalnix on Sep 16 2019, 10:12.

Details

Summary

This is a backport of Core PR15109

Depends on D4079

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 16 2019, 10:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2019, 10:12
Fabien requested changes to this revision.Sep 16 2019, 10:45
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/addrman_tests.cpp
18 ↗(On Diff #11340)

This is a missing dependency: https://github.com/bitcoin/bitcoin/pull/11112

This revision now requires changes to proceed.Sep 16 2019, 10:45
deadalnix requested review of this revision.Sep 16 2019, 11:32
deadalnix added inline comments.
src/test/addrman_tests.cpp
18 ↗(On Diff #11340)

I don't see how blocking this because all the patches to make ctors explicit across the codebase aren't backported.

Fabien accepted this revision.Sep 16 2019, 13:01
This revision is now accepted and ready to land.Sep 16 2019, 13:01
This revision was automatically updated to reflect the committed changes.