Page MenuHomePhabricator

banman: pass the banfile path in
ClosedPublic

Authored by deadalnix on Fri, Sep 20, 15:55.

Details

Summary

There's no need to hard-code the path here. Passing it in means that there are
no ordering concerns wrt establishing the datadir.

This is a partial backport of Core PR14605 : https://github.com/bitcoin/bitcoin/pull/14605/commits/2e56702ecedd83c4b7cb8de9de5c437c8c08e645

Depends on D4114

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Fri, Sep 20, 15:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Sep 20, 15:55
deadalnix edited the summary of this revision. (Show Details)Fri, Sep 20, 16:00
Fabien accepted this revision.Sun, Sep 22, 10:51
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/addrdb.h
92 ↗(On Diff #13035)

explicit is not really necessary here

This revision is now accepted and ready to land.Sun, Sep 22, 10:51
deadalnix updated this revision to Diff 13061.Sun, Sep 22, 11:25

Rebase and nits

This revision was landed with ongoing or failed builds.Sun, Sep 22, 11:26
This revision was automatically updated to reflect the committed changes.