Page MenuHomePhabricator

banman: pass the banfile path in

Authored by deadalnix on Sep 20 2019, 15:55.



There's no need to hard-code the path here. Passing it in means that there are
no ordering concerns wrt establishing the datadir.

This is a partial backport of Core PR14605 :

Depends on D4114

Test Plan
make check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 20 2019, 15:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2019, 15:55
deadalnix edited the summary of this revision. (Show Details)Sep 20 2019, 16:00
Fabien accepted this revision.Sep 22 2019, 10:51
Fabien added a subscriber: Fabien.
Fabien added inline comments.
92 ↗(On Diff #13035)

explicit is not really necessary here

This revision is now accepted and ready to land.Sep 22 2019, 10:51
deadalnix updated this revision to Diff 13061.Sep 22 2019, 11:25

Rebase and nits

This revision was landed with ongoing or failed builds.Sep 22 2019, 11:26
This revision was automatically updated to reflect the committed changes.