Page MenuHomePhabricator

banman: pass the banfile path in
ClosedPublic

Authored by deadalnix on Sep 20 2019, 15:55.

Details

Summary

There's no need to hard-code the path here. Passing it in means that there are
no ordering concerns wrt establishing the datadir.

This is a partial backport of Core PR14605 : https://github.com/bitcoin/bitcoin/pull/14605/commits/2e56702ecedd83c4b7cb8de9de5c437c8c08e645

Depends on D4114

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
banfile
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7544
Build 13128: Bitcoin ABC Buildbot (legacy)
Build 13127: arc lint + arc unit

Event Timeline

Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/addrdb.h
92 ↗(On Diff #13035)

explicit is not really necessary here

This revision is now accepted and ready to land.Sep 22 2019, 10:51
This revision was landed with ongoing or failed builds.Sep 22 2019, 11:26
This revision was automatically updated to reflect the committed changes.