Page MenuHomePhabricator

banman: create and split out banman
ClosedPublic

Authored by deadalnix on Sep 20 2019, 12:35.

Details

Summary

Some say he has always been.

This is a partial backport of Core PR14605 : https://github.com/bitcoin/bitcoin/pull/14605/commits/4c0d961eb0d7825a1e6f8389d7f5545114ee18c6

Depends on D4091

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 20 2019, 12:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2019, 12:35
Fabien requested changes to this revision.Sep 20 2019, 15:34
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net.cpp
2527 ↗(On Diff #13025)

Move below

src/net.h
143 ↗(On Diff #13025)

Move comment above

src/net_processing.h
39 ↗(On Diff #13025)

The explicit keyword is removed in the PR

This revision now requires changes to proceed.Sep 20 2019, 15:34
deadalnix updated this revision to Diff 13037.Sep 20 2019, 16:31

Move comments around and remove explicit keyword

This revision is now accepted and ready to land.Sep 22 2019, 10:40
This revision was automatically updated to reflect the committed changes.