Page MenuHomePhabricator
Differential D4114

banman: create and split out banman
ClosedPublic
Actions

Authored by deadalnix on Sep 20 2019, 12:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING47d52f2e501f: banman: create and split out banman
rABC47d52f2e501f: banman: create and split out banman
Summary

Some say he has always been.

This is a partial backport of Core PR14605 : https://github.com/bitcoin/bitcoin/pull/14605/commits/4c0d961eb0d7825a1e6f8389d7f5545114ee18c6

Depends on D4091

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 20 2019, 12:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2019, 12:35
teamcity added a comment.Sep 20 2019, 12:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7519: Diff 13025.Sep 20 2019, 12:47
teamcity added a comment.Sep 20 2019, 12:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien requested changes to this revision.Sep 20 2019, 15:34
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net.cpp
2527 ↗(On Diff #13025)

Move below

src/net.h
143 ↗(On Diff #13025)

Move comment above

src/net_processing.h
39 ↗(On Diff #13025)

The explicit keyword is removed in the PR

This revision now requires changes to proceed.Sep 20 2019, 15:34
deadalnix added a child revision: D4117: banman: pass the banfile path in.Sep 20 2019, 16:00
deadalnix updated this revision to Diff 13037.Sep 20 2019, 16:31

Move comments around and remove explicit keyword

teamcity added a comment.Sep 20 2019, 16:31

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 20 2019, 16:42

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7527: Diff 13037.Sep 20 2019, 16:42
Fabien accepted this revision.Sep 22 2019, 10:40

Macro batman_approves:

This revision is now accepted and ready to land.Sep 22 2019, 10:40
Closed by commit rABC47d52f2e501f: banman: create and split out banman (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by deadalnix). · Explain WhySep 22 2019, 11:21
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC47d52f2e501f: banman: create and split out banman.
deadalnix added a commit: rSTAGING47d52f2e501f: banman: create and split out banman.Sep 27 2019, 22:46

Revision Contents
Changeset List

PathSize
src/
20 lines
interfaces/
12 lines
86 lines
108 lines
8 lines
25 lines
rpc/
39 lines
test/
28 lines
51 lines
3 lines
1 line

Diff 13060

View Options

src/init.cpp

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/test/avalanche_tests.cpp

Loading...
View Options

src/test/denialofservice_tests.cpp

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...
View Options

src/test/test_bitcoin_main.cpp

Loading...