scripted-diff: batch-recase BanMan variables
ClosedPublic
Actions

Authored by deadalnix on Sep 21 2019, 11:56.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING8d88b38a5747: scripted-diff: batch-recase BanMan variables
rABC8d88b38a5747: scripted-diff: batch-recase BanMan variables

Summary

-BEGIN VERIFY SCRIPT-
sed -i "s/banMap/banmap/g" src/banman.h src/banman.cpp
sed -i "s/netAddr/net_addr/g" src/banman.h src/banman.cpp
sed -i "s/sinceUnixEpoch/since_unix_epoch/g" src/banman.h src/banman.cpp
sed -i "s/bantimeoffset/ban_time_offset/g" src/banman.h src/banman.cpp
sed -i "s/subNet/sub_net/g" src/banman.h src/banman.cpp
sed -i "s/banReason/ban_reason/g" src/banman.h src/banman.cpp
sed -i "s/notifyUI/notify_ui/g" src/banman.h src/banman.cpp
sed -i "s/banEntry/ban_entry/g" src/banman.h src/banman.cpp
sed -i "s/nStart/n_start/g" src/banman.h src/banman.cpp
-END VERIFY SCRIPT-

This is a partial backport of Core PR14605 : https://github.com/bitcoin/bitcoin/pull/14605/commits/18185b57c32d0a43afeca4c125b9352c692923e9

Depends on D4129

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 21 2019, 11:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2019, 11:56

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7540: Diff 13055.Sep 21 2019, 12:11

Fabien edited the summary of this revision. (Show Details)Sep 22 2019, 11:29

Fabien requested changes to this revision.Sep 22 2019, 11:48

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/banman.h
41 ↗	(On Diff #13055)	If I'm trying to see a logical naming here, I think that should be `chain_params`, but `chainParams` and `chainparams` are used almost everywhere through the codebase (almost 50/50). From the developer notes: `Use CamelCase for functions/methods, and lowerCamelCase for variables`, so I'd better leave `chainParams`. That also matches the script from the summary.