Page MenuHomePhabricator
Differential D4091

Use C++11 default member initializers
ClosedPublic
Actions

Authored by deadalnix on Sep 16 2019, 10:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING825e09ba4a76: Use C++11 default member initializers
rABC825e09ba4a76: Use C++11 default member initializers
Summary

This is a backport of Core PR15109

Depends on D4079

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15109
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7476
Build 12995: Bitcoin ABC Buildbot (legacy)
Build 12994: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 16 2019, 10:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2019, 10:12
teamcity added a comment.Sep 16 2019, 10:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 16 2019, 10:21

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7476: Diff 11340.Sep 16 2019, 10:21
Fabien requested changes to this revision.Sep 16 2019, 10:45
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/test/addrman_tests.cpp
18

This is a missing dependency: https://github.com/bitcoin/bitcoin/pull/11112

This revision now requires changes to proceed.Sep 16 2019, 10:45
deadalnix requested review of this revision.Sep 16 2019, 11:32
deadalnix added inline comments.
src/test/addrman_tests.cpp
18

I don't see how blocking this because all the patches to make ctors explicit across the codebase aren't backported.

deadalnix updated this revision to Diff 11344.Sep 16 2019, 11:45

Extract D4093

teamcity added a comment.Sep 16 2019, 11:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 16 2019, 11:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 16 2019, 11:56

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7479: Diff 11344.Sep 16 2019, 11:56
Fabien accepted this revision.Sep 16 2019, 13:01
This revision is now accepted and ready to land.Sep 16 2019, 13:01
deadalnix added a child revision: D4114: banman: create and split out banman.Sep 20 2019, 12:35
Closed by commit rABC825e09ba4a76: Use C++11 default member initializers (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhySep 21 2019, 10:05
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC825e09ba4a76: Use C++11 default member initializers.
deadalnix added a commit: rSTAGING825e09ba4a76: Use C++11 default member initializers.Sep 27 2019, 22:46

Revision Contents
Changeset List

Diff 11340

View Options

src/addrman.h

Loading...
View Options

src/httpserver.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/qt/bantablemodel.cpp

Loading...
View Options

src/qt/peertablemodel.cpp

Loading...
View Options

src/qt/recentrequeststablemodel.h

Loading...
View Options

src/qt/recentrequeststablemodel.cpp

Loading...
View Options

src/qt/walletmodel.h

Loading...
View Options

src/qt/walletmodel.cpp

Loading...
View Options

src/test/addrman_tests.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...