Page MenuHomePhabricator
Differential D4095

[contrib] Support ARM symbol check
ClosedPublic
Actions

Authored by Fabien on Sep 16 2019, 15:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING5263b1d033cb: [contrib] Support ARM symbol check
rABC5263b1d033cb: [contrib] Support ARM symbol check
Summary

Backport of core PR13724
https://github.com/bitcoin/bitcoin/pull/13724/files

The Risc-v section is not included as this platform is not supported.

Depends on D4185.

Test Plan

Run the linux gitian build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13724
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7481
Build 13005: Bitcoin ABC Buildbot (legacy)
Build 13004: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 16 2019, 15:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2019, 15:09
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 16 2019, 15:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien planned changes to this revision.Sep 16 2019, 15:10

Will request for review after the gitian build succeeded.

teamcity added a comment.Sep 16 2019, 15:11

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Sep 16 2019, 15:16

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7481: Diff 11347.Sep 16 2019, 15:16
teamcity added a comment.Sep 16 2019, 15:50

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Fabien added a comment.Sep 17 2019, 12:16

Do not review: this won't work with cross gcc < 7, and our gitian stretch base has only gcc 6.

Fabien mentioned this in D4167: Add support for Glibc version 2.28.Sep 28 2019, 06:45
Fabien updated this revision to Diff 13284.Oct 1 2019, 12:47
Fabien edited the summary of this revision. (Show Details)
Fabien added a parent revision: D4185: Migrate Gitian container to Debian 10 Buster.

Rebase on top of D4185.

teamcity added a comment.Oct 1 2019, 12:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 1 2019, 12:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7642: Diff 13284.Oct 1 2019, 12:57
deadalnix accepted this revision.Oct 1 2019, 18:42
deadalnix added inline comments.
contrib/devtools/symbol-check.py
50 ↗(On Diff #13284)

I'm sure there is a way this can be formatted better.

This revision is now accepted and ready to land.Oct 1 2019, 18:42
Closed by commit rABC5263b1d033cb: [contrib] Support ARM symbol check (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by Fabien). · Explain WhyNov 1 2019, 20:20
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC5263b1d033cb: [contrib] Support ARM symbol check.
Fabien added a commit: rSTAGING5263b1d033cb: [contrib] Support ARM symbol check.Apr 7 2020, 21:35

Revision Contents
Changeset List

PathSize
contrib/
devtools/
36 lines
gitian-descriptors/
12 lines

Diff 11347

View Options

contrib/devtools/symbol-check.py

Loading...
View Options

contrib/gitian-descriptors/gitian-linux.yml

Loading...