Page MenuHomePhabricator
Differential D480

Add fork block checkpoints and update defaultAssumedValid and min chain work (main and testnet)
ClosedPublic
Actions

Authored by freetrader on Aug 23 2017, 16:29.

Details

Reviewers
deadalnix
sickpig
Group Reviewers
Restricted Project
Commits
rSTAGING0ee4822fbc31: Add fork block checkpoints and update defaultAssumedValid and min chain work…
rABC0ee4822fbc31: Add fork block checkpoints and update defaultAssumedValid and min chain work…
Summary

Changes to chain params:

  • added fork block checkpoints for mainnet and testnet3
  • update defaultAssumeValid for both chains
  • updated nMinimumChainWork to match the defaultAssumeValid blocks

Having a check point on fork block means nodes cannot be led onto wrong
UAHF-compatible chain.

Knowing that you are on right Bitcoin Cash chain after the fork block
can be used to optimize some code which determines whether we are pre-fork
or post-fork.

Test Plan

make check
Run bitcoind with the changes on mainnet and testnet

Diff Detail

Repository
rABC Bitcoin ABC
Branch
update_checkpoints
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 752
Build 752: arc lint + arc unit

Event Timeline

freetrader created this revision.Aug 23 2017, 16:29
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptAug 23 2017, 16:29
Harbormaster completed remote builds in B752: Diff 1203.Aug 23 2017, 16:29
freetrader mentioned this in D479: Added fActiveChainTipIsUAHF as a global flag to indicate active chain is UAHF (potentially net_processing code needs this for NODE_CASH stuff).Aug 23 2017, 16:41
sickpig added a subscriber: sickpig.Aug 23 2017, 19:51

wonder if we could just add the 478559 and then rely on assumevalid to lessen the load due to validation during the sync step.

freetrader added a comment.EditedAug 23 2017, 20:06

@sickpig : Yes, you are right. I will update the definitions accordingly (also need to update testnet's defaultAssumeValid hash).

I am wondering about chainTxData which is used by GuessVerificationProgress() . That looks like it's fairly outdated as well. But that could be done in a separate diff.

deadalnix accepted this revision.Aug 23 2017, 23:46

please add a comment for the fork block.

This revision is now accepted and ready to land.Aug 23 2017, 23:46
freetrader updated this revision to Diff 1204.Aug 24 2017, 06:41

Add comments from review, update minimum chain work and defaultAssumeValid hashes

Harbormaster completed remote builds in B753: Diff 1204.Aug 24 2017, 06:41
freetrader requested review of this revision.Aug 24 2017, 06:45
freetrader edited edge metadata.

Changes made based on previous review comments, quite a few so I'm returning to review:

  • update defaultAssumeValid for mainnet and testnet3
  • updated nMinimumChainWork to match the defaultAssumeValid blocks
  • added fork block checkpoint for testnet3
  • added comment ahead of fork block checkpoints

I've run this patch on mainnet and testnet3 to test, and also ran extended regtest suite over it.

sickpig accepted this revision as: sickpig.Aug 24 2017, 07:42
This revision is now accepted and ready to land.Aug 24 2017, 07:42
freetrader retitled this revision from Add fork block checkpoint and update most recent checkpoint (mainnet) to Add fork block checkpoints and update defaultAssumedValid and min chain work (main and testnet).Aug 24 2017, 09:13
freetrader edited the summary of this revision. (Show Details)
freetrader edited the test plan for this revision. (Show Details)
Closed by commit rABC0ee4822fbc31: Add fork block checkpoints and update defaultAssumedValid and min chain work… (authored by freetrader, committed by freetrader). · Explain WhyAug 24 2017, 09:15
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
6 lines

Diff 1203

View Options

src/chainparams.cpp

Loading...