Page MenuHomePhabricator
Differential D491

Add SipHashUint256Extra as a specialization of siphash for a 256bits int and a 32 bit one.
ClosedPublic
Actions

Authored by deadalnix on Aug 26 2017, 19:27.

Details

Reviewers
freetrader
CCulianu
Group Reviewers
Restricted Project
Commits
rSTAGING42a837318e8c: Add SipHashUint256Extra as a specialization of siphash for a 256bits int and a…
rABC42a837318e8c: Add SipHashUint256Extra as a specialization of siphash for a 256bits int and a…
Summary

This is going to be used to hash outpoints. This is part of the work started with D342 .

Depends on 490

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
siphashextra
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 765
Build 765: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 26 2017, 19:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2017, 19:27
Harbormaster completed remote builds in B765: Diff 1221.Aug 26 2017, 19:27
CCulianu edited edge metadata.Aug 27 2017, 10:12

Looks Good To Me. However I can't compile it as it complains about missing FastRandomContext::rand64().

Please rebase this?

CCulianu mentioned this in D490: FastRandomContext improvements and switch to ChaCha20.Aug 27 2017, 10:15
CCulianu accepted this revision.Aug 28 2017, 17:31

Looks good. Approved.

This revision is now accepted and ready to land.Aug 28 2017, 17:31
Closed by commit rABC42a837318e8c: Add SipHashUint256Extra as a specialization of siphash for a 256bits int and a… (authored by deadalnix, committed by deadalnix). · Explain WhyAug 28 2017, 18:09
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
49 lines
test/
17 lines

Diff 1221

View Options

src/hash.h

Loading...
View Options

src/hash.cpp

Loading...
View Options

src/test/hash_tests.cpp

Loading...