Page MenuHomePhabricator
Differential D505

[tests] Remove is_network_split from funtional test cases
ClosedPublic
Actions

Authored by deadalnix on Aug 28 2017, 21:38.

Details

Reviewers
freetrader
CCulianu
Group Reviewers
Restricted Project
Commits
rSTAGINGdc246915f5fa: [tests] Remove is_network_split from funtional test cases
rABCdc246915f5fa: [tests] Remove is_network_split from funtional test cases
Summary

Backport of core's PR10198 + a bug fix + adapation of ABC tests.

Test Plan
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
qanetsplit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 791
Build 791: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 28 2017, 21:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2017, 21:38
Harbormaster completed remote builds in B791: Diff 1259.Aug 28 2017, 21:38
CCulianu accepted this revision.Aug 29 2017, 22:55

This looks good. I like the code refactor -- slightly neater to not call self.start_nodes in each derived class and just move it to the base. All tests pass, as well.

This revision is now accepted and ready to land.Aug 29 2017, 22:55
Closed by commit rABCdc246915f5fa: [tests] Remove is_network_split from funtional test cases (authored by deadalnix, committed by deadalnix). · Explain WhyAug 30 2017, 00:08
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
qa/
rpc-tests/
10 lines
5 lines
7 lines
14 lines
8 lines
9 lines
8 lines
12 lines
6 lines
7 lines
9 lines
8 lines
4 lines
7 lines
4 lines
3 lines
6 lines
4 lines
2 lines
2 lines
3 lines
6 lines
6 lines
3 lines
4 lines
2 lines
9 lines
20 lines
13 lines
10 lines
6 lines
6 lines
12 lines
3 lines
7 lines
8 lines
9 lines
11 lines
7 lines
9 lines
6 lines
3 lines
2 lines
10 lines
3 lines
63 lines
14 lines
2 lines
3 lines
6 lines
5 lines
5 lines
4 lines
4 lines
1 line
test_framework/
57 lines
17 lines
4 lines
4 lines
7 lines
12 lines
3 lines
6 lines
8 lines
2 lines

Diff 1259

View Options

qa/rpc-tests/abandonconflict.py

Loading...
View Options

qa/rpc-tests/abc-cmdline.py

Loading...
View Options

qa/rpc-tests/abc-p2p-fullblocktest.py

Loading...
View Options

qa/rpc-tests/abc-rpc.py

Loading...
View Options

qa/rpc-tests/bip65-cltv-p2p.py

Loading...
View Options

qa/rpc-tests/bip65-cltv.py

Loading...
View Options

qa/rpc-tests/bip68-112-113-p2p.py

Loading...
View Options

qa/rpc-tests/bip68-sequence.py

Loading...
View Options

qa/rpc-tests/bip9-softforks.py

Loading...
View Options

qa/rpc-tests/bipdersig-p2p.py

Loading...
View Options

qa/rpc-tests/bipdersig.py

Loading...
View Options

qa/rpc-tests/blockchain.py

Loading...
View Options

qa/rpc-tests/decodescript.py

Loading...
View Options

qa/rpc-tests/disablewallet.py

Loading...
View Options

qa/rpc-tests/disconnect_ban.py

Loading...
View Options

qa/rpc-tests/forknotify.py

Loading...
View Options

qa/rpc-tests/fundrawtransaction.py

Loading...
View Options

qa/rpc-tests/getblocktemplate_proposals.py

Loading...
View Options

qa/rpc-tests/getchaintips.py

Loading...
View Options

qa/rpc-tests/httpbasics.py

Loading...
View Options

qa/rpc-tests/importmulti.py

Loading...
View Options

qa/rpc-tests/importprunedfunds.py

Loading...
View Options

qa/rpc-tests/invalidateblock.py

Loading...
View Options

qa/rpc-tests/keypool.py

Loading...
View Options

qa/rpc-tests/listsinceblock.py

Loading...
View Options

qa/rpc-tests/listtransactions.py

Loading...
View Options

qa/rpc-tests/maxuploadtarget.py

Loading...
View Options

qa/rpc-tests/mempool_limit.py

Loading...
View Options

qa/rpc-tests/mempool_packages.py

Loading...
View Options

qa/rpc-tests/mempool_reorg.py

Loading...
View Options

qa/rpc-tests/mempool_resurrect_test.py

Loading...
View Options

qa/rpc-tests/mempool_spendcoinbase.py

Loading...
View Options

qa/rpc-tests/merkle_blocks.py

Loading...
View Options

qa/rpc-tests/multi_rpc.py

Loading...
View Options

qa/rpc-tests/nulldummy.py

Loading...
View Options

qa/rpc-tests/p2p-acceptblock.py

Loading...
View Options

qa/rpc-tests/p2p-compactblocks.py

Loading...
View Options

qa/rpc-tests/p2p-feefilter.py

Loading...
View Options

qa/rpc-tests/p2p-leaktests.py

Loading...
View Options

qa/rpc-tests/p2p-mempool.py

Loading...
View Options

qa/rpc-tests/p2p-timeouts.py

Loading...
View Options

qa/rpc-tests/p2p-versionbits-warning.py

Loading...
View Options

qa/rpc-tests/preciousblock.py

Loading...
View Options

qa/rpc-tests/prioritise_transaction.py

Loading...
View Options

qa/rpc-tests/proxy_test.py

Loading...
View Options

qa/rpc-tests/pruning.py

Loading...
View Options

qa/rpc-tests/rawtransactions.py

Loading...
View Options

qa/rpc-tests/receivedby.py

Loading...
View Options

qa/rpc-tests/reindex.py

Loading...
View Options

qa/rpc-tests/rest.py

Loading...
View Options

qa/rpc-tests/rpcnamedargs.py

Loading...
View Options

qa/rpc-tests/sendheaders.py

Loading...
View Options

qa/rpc-tests/signmessages.py

Loading...
View Options

qa/rpc-tests/signrawtransactions.py

Loading...
View Options

qa/rpc-tests/smartfees.py

Loading...
View Options

qa/rpc-tests/test_framework/test_framework.py

Loading...
View Options

qa/rpc-tests/test_framework/util.py

Loading...
View Options

qa/rpc-tests/txn_clone.py

Loading...
View Options

qa/rpc-tests/txn_doublespend.py

Loading...
View Options

qa/rpc-tests/wallet-accounts.py

Loading...
View Options

qa/rpc-tests/wallet-hd.py

Loading...
View Options

qa/rpc-tests/wallet.py

Loading...
View Options

qa/rpc-tests/walletbackup.py

Loading...
View Options

qa/rpc-tests/zapwallettxes.py

Loading...
View Options

qa/rpc-tests/zmq_test.py

Loading...