Page MenuHomePhabricator
Differential D4140

Fix errant newline in make_chainparams
ClosedPublic
Actions

Authored by jasonbcox on Sep 23 2019, 18:31.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING5c01ead3ea53: Fix errant newline in make_chainparams
rABC5c01ead3ea53: Fix errant newline in make_chainparams
Summary

The extra newline in the terminal doesn't really matter, but it gives a bad smell when stdout is redirected to a file.

Test Plan

Before patch:

$ ./make_chainparams.py
0000000000000000030e63e8b8a3e08e25244daf633203c416c91f5b03968641
000000000000000000000000000000000000000000ff5be32693c1c823f2aac5

After patch:

$ ./make_chainparams.py
0000000000000000030e63e8b8a3e08e25244daf633203c416c91f5b03968641
000000000000000000000000000000000000000000ff5be32693c1c823f2aac5

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mcp-newline
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7556
Build 13152: Bitcoin ABC Buildbot (legacy)
Build 13151: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Sep 23 2019, 18:31
Herald added a reviewer: deadalnix. · View Herald TranscriptSep 23 2019, 18:31
teamcity added a comment.Sep 23 2019, 18:31

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 23 2019, 18:35

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7556: Diff 13091!Sep 23 2019, 18:35
jasonbcox updated this revision to Diff 13093.Sep 23 2019, 21:29

Fixed tests

teamcity added a comment.Sep 23 2019, 21:29

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox added a child revision: D4120: Added a script to generate chainparams constants from intermediate files.Sep 23 2019, 21:33
jasonbcox edited the test plan for this revision. (Show Details)
teamcity added a comment.Sep 23 2019, 21:39

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7558: Diff 13093.Sep 23 2019, 21:39
Fabien accepted this revision.Sep 24 2019, 09:14
This revision is now accepted and ready to land.Sep 24 2019, 09:14
Closed by commit rABC5c01ead3ea53: Fix errant newline in make_chainparams (authored by jasonbcox). · Explain WhySep 24 2019, 16:32
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC5c01ead3ea53: Fix errant newline in make_chainparams.
jasonbcox added a commit: rSTAGING5c01ead3ea53: Fix errant newline in make_chainparams.Sep 27 2019, 22:48

Revision Contents
Changeset List

PathSize
contrib/
devtools/
chainparams/
2 lines

Diff 13091

View Options

contrib/devtools/chainparams/make_chainparams.py

Loading...