Page MenuHomePhabricator
Differential D4199

Introduce Span type and use it instead of FLATDATA
ClosedPublic
Actions

Authored by deadalnix on Oct 2 2019, 14:10.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING53a7c7e4eef4: Introduce Span type and use it instead of FLATDATA
rABC53a7c7e4eef4: Introduce Span type and use it instead of FLATDATA
Summary
  • Add Slice: a (pointer, size) array view that acts like a container
  • Support serializing Span<unsigned char> and use that instead of FLATDATA

This is a backport of Core PR12886

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12886
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7665
Build 13369: Bitcoin ABC Buildbot (legacy)
Build 13368: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 2 2019, 14:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2019, 14:10
teamcity added a comment.Oct 2 2019, 14:10

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 2 2019, 14:26

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7665: Diff 13319.Oct 2 2019, 14:26
Fabien requested changes to this revision.Oct 3 2019, 19:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/span.h
47

#endif // BITCOIN_SPAN_H
Linter update coming soon.

This revision now requires changes to proceed.Oct 3 2019, 19:50
deadalnix updated this revision to Diff 13346.Oct 3 2019, 21:41

Add header guard comment

teamcity added a comment.Oct 3 2019, 21:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7684: Diff 13346.Oct 3 2019, 21:56
teamcity added a comment.Oct 3 2019, 21:56

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Oct 4 2019, 06:35
This revision is now accepted and ready to land.Oct 4 2019, 06:35
Closed by commit rABC53a7c7e4eef4: Introduce Span type and use it instead of FLATDATA (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyOct 4 2019, 12:21
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC53a7c7e4eef4: Introduce Span type and use it instead of FLATDATA.
deadalnix added a commit: rSTAGING53a7c7e4eef4: Introduce Span type and use it instead of FLATDATA.Oct 9 2019, 20:11

Revision Contents
Changeset List

PathSize
src/
1 line
9 lines
3 lines
52 lines
47 lines

Diff 13319

View Options

src/Makefile.am

Loading...
View Options

src/compressor.h

Loading...
View Options

src/netaddress.h

Loading...
View Options

src/serialize.h

Loading...
View Options

src/span.h

Loading...