Differential D4209

Inline Sign1 and SignN
ClosedPublic
Actions

Authored by deadalnix on Oct 3 2019, 22:51.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING96d036525db2: Inline Sign1 and SignN
rABC96d036525db2: Inline Sign1 and SignN

Summary

Sign1 and SignN are kind of redundant so remove them and inline their
behavior into SignStep

This is a partial backport of Core PR13425 : https://github.com/bitcoin/bitcoin/pull/13425/commits/b6edb4f5e6e0bf0f9c7dd26a125849f0103b44cd

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

inlinesign

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7685
Build 13409: Bitcoin ABC Buildbot (legacy)
Build 13408: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 3 2019, 22:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2019, 22:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7685: Diff 13347.Oct 3 2019, 23:08

deadalnix added a child revision: D4210: Make SignatureData able to store signatures and scripts.Oct 4 2019, 00:42

Fabien accepted this revision.Oct 4 2019, 08:28

This revision is now accepted and ready to land.Oct 4 2019, 08:28

Closed by commit rABC96d036525db2: Inline Sign1 and SignN (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 4 2019, 12:06

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC96d036525db2: Inline Sign1 and SignN.

deadalnix added a commit: rSTAGING96d036525db2: Inline Sign1 and SignN.Oct 9 2019, 20:11

Revision Contents
Changeset List

Path

Size

src/

script/

sign.cpp

71 lines

Diff 13347

View Options

Inline Sign1 and SignNClosedPublicActions