Paths

Table of Contentst

Differential D4290

[CMAKE] Build the OSX application bundle for bitcoin qt
ClosedPublic
Actions

Authored by Fabien on Oct 24 2019, 08:29.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING27ea18e5ba99: [CMAKE] Build the OSX application bundle for bitcoin qt
rABC27ea18e5ba99: [CMAKE] Build the OSX application bundle for bitcoin qt

Summary

When building/cross building for OSX, create an application bundle that
can run natively on OSX.
This is a first step toward generating an installer for OSX.

Test Plan

On OSX (or cross build):

ninja BitcoinABC-Qt

Check there is an app bundle (BitcoinABC-Qt.app) created under
src/qt.
Check on OSX that the bundle has the correct icon, details and can be
run.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_bundle_bitcoin_qt

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7858
Build 13736: Bitcoin ABC Buildbot (legacy)
Build 13735: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 24 2019, 08:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2019, 08:29

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien edited the test plan for this revision. (Show Details)Oct 24 2019, 08:31

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7858: Diff 13681.Oct 24 2019, 08:38

deadalnix requested changes to this revision.Oct 25 2019, 15:17

deadalnix added inline comments.

src/qt/CMakeLists.txt
306	This needs to be prepossessed by cmake, and the result of the prepossessing passed down, no?

This revision now requires changes to proceed.Oct 25 2019, 15:17

Fabien requested review of this revision.Oct 25 2019, 16:18

Fabien added inline comments.

src/qt/CMakeLists.txt
306	This is done automatically by cmake. The template file is filled with the bundle properties below, this is a facility to merge 2 commands into 1.

deadalnix accepted this revision.Oct 29 2019, 22:51

This revision is now accepted and ready to land.Oct 29 2019, 22:51

Closed by commit rABC27ea18e5ba99: [CMAKE] Build the OSX application bundle for bitcoin qt (authored by Fabien). · Explain WhyOct 30 2019, 14:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC27ea18e5ba99: [CMAKE] Build the OSX application bundle for bitcoin qt.

Fabien added a commit: rSTAGING27ea18e5ba99: [CMAKE] Build the OSX application bundle for bitcoin qt.Apr 7 2020, 21:32

Revision Contents
Changeset List

Path

Size

share/

qt/

Info.plist.cmake.in

106 lines

src/

qt/

CMakeLists.txt

26 lines

Diff 13681

View Options

share/qt/Info.plist.cmake.in