Page MenuHomePhabricator
Differential D4288

Refactor transaction creation and transaction funding logic
ClosedPublic
Actions

Authored by deadalnix on Oct 23 2019, 17:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING664862e1af6c: Refactor transaction creation and transaction funding logic
rABC664862e1af6c: Refactor transaction creation and transaction funding logic
Summary

In preparation for more create transaction and fund transcation RPCs,
refactor the transaction creation and funding logic into separate
functions.

This is a partial backport of Core PR13557 : https://github.com/bitcoin/bitcoin/pull/13557/commits/58a8e28918025c28f19ba19cbaa4a72374162942

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
transactioncreationlogic
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7883
Build 13781: Bitcoin ABC Buildbot (legacy)
Build 13780: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 23 2019, 17:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2019, 17:44
teamcity added a comment.Oct 23 2019, 17:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 23 2019, 17:55

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7852: Diff 13669.Oct 23 2019, 17:55
Fabien requested changes to this revision.Oct 24 2019, 10:00
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/rawtransaction.cpp
593 ↗(On Diff #13669)

No longer here, remove.

This revision now requires changes to proceed.Oct 24 2019, 10:00
deadalnix added inline comments.Oct 27 2019, 22:51
src/rpc/rawtransaction.cpp
593 ↗(On Diff #13669)

This is in the original material and in the back ported PR, so why is that something to be changed?

deadalnix updated this revision to Diff 13722.Oct 27 2019, 23:24

rebase, ping?

teamcity added a comment.Oct 27 2019, 23:24

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 27 2019, 23:34

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7883: Diff 13722.Oct 27 2019, 23:34
Fabien requested changes to this revision.Oct 28 2019, 07:13
Fabien added inline comments.
src/rpc/rawtransaction.cpp
422 ↗(On Diff #13669)

Here

586 ↗(On Diff #13669)

Nit: move comment above

593 ↗(On Diff #13669)

Unless I'm blind, this is moved in the original PR, and duplicated in this diff.

This revision now requires changes to proceed.Oct 28 2019, 07:13
deadalnix added inline comments.Oct 29 2019, 01:37
src/rpc/rawtransaction.cpp
593 ↗(On Diff #13669)

I see. Let me fix this.

deadalnix added inline comments.Oct 29 2019, 02:34
src/rpc/rawtransaction.cpp
586 ↗(On Diff #13669)

Because the comment relates to UniValueType, it's better here. Putting it before just don't layout properly.

deadalnix updated this revision to Diff 13738.Oct 29 2019, 02:35

Move outputs_is_obj business instead of copying it.

teamcity added a comment.Oct 29 2019, 02:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 29 2019, 02:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7893: Diff 13738.Oct 29 2019, 02:44
Fabien accepted this revision.Oct 29 2019, 07:01
This revision is now accepted and ready to land.Oct 29 2019, 07:01
Closed by commit rABC664862e1af6c: Refactor transaction creation and transaction funding logic (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 29 2019, 12:30
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC664862e1af6c: Refactor transaction creation and transaction funding logic.
deadalnix added a commit: rSTAGING664862e1af6c: Refactor transaction creation and transaction funding logic.Apr 7 2020, 21:30

Revision Contents
Changeset List

PathSize
src/
rpc/
7 lines
140 lines
wallet/
231 lines

Diff 13722

View Options

src/rpc/rawtransaction.h

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...