Page MenuHomePhabricator

Refactor transaction creation and transaction funding logic
ClosedPublic

Authored by deadalnix on Oct 23 2019, 17:44.

Details

Summary

In preparation for more create transaction and fund transcation RPCs,
refactor the transaction creation and funding logic into separate
functions.

This is a partial backport of Core PR13557 : https://github.com/bitcoin/bitcoin/pull/13557/commits/58a8e28918025c28f19ba19cbaa4a72374162942

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
transactioncreationlogic
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7883
Build 13781: Bitcoin ABC Buildbot (legacy)
Build 13780: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Oct 24 2019, 10:00
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/rawtransaction.cpp
593 ↗(On Diff #13669)

No longer here, remove.

This revision now requires changes to proceed.Oct 24 2019, 10:00
src/rpc/rawtransaction.cpp
593 ↗(On Diff #13669)

This is in the original material and in the back ported PR, so why is that something to be changed?

Fabien requested changes to this revision.Oct 28 2019, 07:13
Fabien added inline comments.
src/rpc/rawtransaction.cpp
422 ↗(On Diff #13669)

Here

586 ↗(On Diff #13669)

Nit: move comment above

593 ↗(On Diff #13669)

Unless I'm blind, this is moved in the original PR, and duplicated in this diff.

This revision now requires changes to proceed.Oct 28 2019, 07:13
src/rpc/rawtransaction.cpp
593 ↗(On Diff #13669)

I see. Let me fix this.

src/rpc/rawtransaction.cpp
586 ↗(On Diff #13669)

Because the comment relates to UniValueType, it's better here. Putting it before just don't layout properly.

Move outputs_is_obj business instead of copying it.

This revision is now accepted and ready to land.Oct 29 2019, 07:01