Create wallet RPCs for PSBT
ClosedPublic
Actions

Authored by deadalnix on Nov 2 2019, 01:43.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGf25d2ad300d9: Create wallet RPCs for PSBT
rABCf25d2ad300d9: Create wallet RPCs for PSBT

Summary

walletprocesspsbt takes a PSBT format transaction, updates the
PSBT with any inputs related to this wallet, signs, and finalizes
the transaction. There is also an option to not sign and just
update.

walletcreatefundedpsbt creates a PSBT from user provided data
in the same form as createrawtransaction. It also funds the transaction
and takes an options argument in the same form as fundrawtransaction.
The resulting PSBT is blank with no input or output data filled
in.

This is a partial backport of Core PR13557 : https://github.com/bitcoin/bitcoin/pull/13557/commits/a4b06fb42eb0ad94e562ca839391b57e69285136

Depends on D4351

Test Plan

Unfortunately, the test have all been dumped at once at the end.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

walletrpcpsbt

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7953
Build 13909: Bitcoin ABC Buildbot (legacy)
Build 13908: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 2 2019, 01:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2019, 01:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a child revision: D4353: Tests for PSBT.Nov 2 2019, 01:48

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7953: Diff 13869.Nov 2 2019, 02:00

This deserves release notes.

src/wallet/rpcwallet.cpp
4694	Nit: `Sighash` vs `sighash`
4769	`default=ALL\|FORKID`
4807	This doesn't check for `FORKID`: if (!nHashType.hasForkId()) { throw JSONRPCError(RPC_INVALID_PARAMETER, "Signature must use SIGHASH_FORKID"); }