Page MenuHomePhabricator
Differential D4350

[CMAKE] Generate the split-debug.sh script
ClosedPublic
Actions

Authored by Fabien on Nov 1 2019, 21:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGe20d900747f1: [CMAKE] Generate the split-debug.sh script
rABCe20d900747f1: [CMAKE] Generate the split-debug.sh script
Summary

The split-debug.sh script is generated from a template at build time,
and used by the linux gitian build to separate the debug symbols from
the stripped binaries.

Test Plan

For all the linux platforms:

cmake ..

Check the <build_dir>/contrib/devtools/split-debug.sh script is
generated as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_split_debug
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7956
Build 13915: Bitcoin ABC Buildbot (legacy)
Build 13914: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 1 2019, 21:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2019, 21:06
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 1 2019, 21:06

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7951: Diff 13867.Nov 1 2019, 21:14
teamcity added a comment.Nov 1 2019, 21:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien updated this revision to Diff 13872.Nov 2 2019, 08:39

Fix permissions.

teamcity added a comment.Nov 2 2019, 08:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 2 2019, 08:48

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7956: Diff 13872.Nov 2 2019, 08:48
Fabien added a child revision: D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.Nov 2 2019, 11:34
deadalnix requested changes to this revision.Nov 2 2019, 17:02
deadalnix added inline comments.
contrib/devtools/CMakeLists.txt
19

Can you explain why this dance is necessary?

24

Does this break deps tracking?

This revision now requires changes to proceed.Nov 2 2019, 17:02
Fabien added inline comments.Nov 4 2019, 08:57
contrib/devtools/CMakeLists.txt
19

file(COPY/INSTALL) is the only cmake directive to change permissions on a file, and the script needs to be executable while the template should not.

24

The copy will update the file and cause cmake to re-configure every time, which is not ideal. I'll fix that.

Fabien updated this revision to Diff 13884.Nov 4 2019, 08:58

Avoid re-configuring at each call.

teamcity added a comment.Nov 4 2019, 08:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7966: Diff 13884.Nov 4 2019, 09:08
teamcity added a comment.Nov 4 2019, 09:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Nov 7 2019, 15:12
This revision is now accepted and ready to land.Nov 7 2019, 15:12
Closed by commit rABCe20d900747f1: [CMAKE] Generate the split-debug.sh script (authored by Fabien). · Explain WhyNov 7 2019, 16:18
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe20d900747f1: [CMAKE] Generate the split-debug.sh script.
Fabien removed a child revision: D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.Nov 11 2019, 11:52
Fabien added a commit: rSTAGINGe20d900747f1: [CMAKE] Generate the split-debug.sh script.Apr 7 2020, 21:37

Revision Contents
Changeset List

PathSize
contrib/
devtools/
23 lines
12 lines
4 lines

Diff 13872

View Options

contrib/devtools/CMakeLists.txt

Loading...
View Options

contrib/devtools/split-debug.sh.cmake.in

Loading...
View Options

contrib/devtools/split-debug.sh.in

Loading...