Fix various linter issues
ClosedPublic
Actions

Authored by Fabien on Nov 4 2019, 09:20.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGedef9dab169a: Fix various linter issues
rABCedef9dab169a: Fix various linter issues

Summary

Running arc lint everything returned me 2 warnings, 1 from shellcheck
and one from clang-format.

Test Plan

Should return no error nor warning:

arc lint --everything

Run some CI build.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_linter_issues

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7967
Build 13937: Bitcoin ABC Buildbot (legacy)
Build 13936: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 4 2019, 09:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 4 2019, 09:20

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7967: Diff 13885.Nov 4 2019, 09:29

jasonbcox accepted this revision.Nov 4 2019, 17:12

This revision is now accepted and ready to land.Nov 4 2019, 17:12

Closed by commit rABCedef9dab169a: Fix various linter issues (authored by Fabien). · Explain WhyNov 4 2019, 20:39

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCedef9dab169a: Fix various linter issues.

Fabien added a commit: rSTAGINGedef9dab169a: Fix various linter issues.Apr 7 2020, 21:35

Revision Contents
Changeset List

Path

Size

contrib/

teamcity/

build-configurations.sh

2 lines

src/

addrman.cpp

4 lines

Diff 13885

View Options

contrib/teamcity/build-configurations.sh