[CMAKE] Use native strip on OSX
ClosedPublic
Actions

Authored by Fabien on Nov 5 2019, 09:39.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING92a22eb2564f: [CMAKE] Use native strip on OSX
rABC92a22eb2564f: [CMAKE] Use native strip on OSX

Summary

This will allow for running the install/strip target when cross building
for OSX.

Test Plan

mkdir buildcmake && cd buildcmake
mkdir install
cmake -GNinja .. DCMAKE_INSTALL_PREFIX=install \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/OSX.cmake
ninja install/strip

Check the executables are stripped (compare the size vs non stripped).

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 5 2019, 09:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 09:39

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7986: Diff 13920.Nov 5 2019, 09:48

jasonbcox accepted this revision.Nov 5 2019, 16:37

This revision is now accepted and ready to land.Nov 5 2019, 16:37

Closed by commit rABC92a22eb2564f: [CMAKE] Use native strip on OSX (authored by Fabien). · Explain WhyNov 6 2019, 10:44

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC92a22eb2564f: [CMAKE] Use native strip on OSX.

Fabien added a commit: rSTAGING92a22eb2564f: [CMAKE] Use native strip on OSX.Apr 7 2020, 21:37

Revision Contents
Changeset List

Path

Size

cmake/

platforms/

OSX.cmake

3 lines

Diff 13965

View Options

[CMAKE] Use native strip on OSXClosedPublicActions