Differential D4427

Fix unecessary copies in rpcwallet.cpp
ClosedPublic
Actions

Authored by deadalnix on Nov 11 2019, 15:56.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING28f918df531c: Fix unecessary copies in rpcwallet.cpp
rABC28f918df531c: Fix unecessary copies in rpcwallet.cpp

Summary

The eroneous copies were added in D3949

Test Plan

make

Check that warning are gone.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

forwarning

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8062
Build 14119: Bitcoin ABC Buildbot (legacy)
Build 14118: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 11 2019, 15:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2019, 15:56

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8062: Diff 14053.Nov 11 2019, 16:06

jasonbcox accepted this revision.Nov 11 2019, 17:43

This revision is now accepted and ready to land.Nov 11 2019, 17:43

Closed by commit rABC28f918df531c: Fix unecessary copies in rpcwallet.cpp (authored by deadalnix). · Explain WhyNov 11 2019, 22:16

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC28f918df531c: Fix unecessary copies in rpcwallet.cpp.

deadalnix added a commit: rSTAGING28f918df531c: Fix unecessary copies in rpcwallet.cpp.Apr 7 2020, 21:40

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

6 lines

Diff 14053

View Options

Fix unecessary copies in rpcwallet.cppClosedPublicActions