[CMAKE] Only build the bitcoin-qt application bundle on OSX
ClosedPublic
Actions

Authored by Fabien on Nov 13 2019, 14:30.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING54886a6c6083: [CMAKE] Only build the bitcoin-qt application bundle on OSX
rABC54886a6c6083: [CMAKE] Only build the bitcoin-qt application bundle on OSX

Summary

Follow-up for the discussion in D4426.

When building for OSX, the bitcoin-qt target will build the application
bundle.

Test Plan

ninja bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_merge_bitcoin_qt_bundle

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8091
Build 14171: Bitcoin ABC Buildbot (legacy)
Build 14170: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 13 2019, 14:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2019, 14:30

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4438: [CMAKE] Use a stripped binary to build the dist and DMG for OSX.Nov 13 2019, 14:39

Harbormaster completed remote builds in B8091: Diff 14101.Nov 13 2019, 14:40

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Nov 17 2019, 22:44

This revision is now accepted and ready to land.Nov 17 2019, 22:44

Closed by commit rABC54886a6c6083: [CMAKE] Only build the bitcoin-qt application bundle on OSX (authored by Fabien). · Explain WhyNov 18 2019, 12:00

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC54886a6c6083: [CMAKE] Only build the bitcoin-qt application bundle on OSX.

Fabien added a commit: rSTAGING54886a6c6083: [CMAKE] Only build the bitcoin-qt application bundle on OSX.Apr 7 2020, 21:42

Revision Contents
Changeset List

Path

Size

src/

qt/

CMakeLists.txt

21 lines

Diff 14101

View Options

[CMAKE] Only build the bitcoin-qt application bundle on OSXClosedPublicActions